Tests/numpy 2.0 #44
Merged
Tests/numpy 2.0 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 78.13% 78.13%
=======================================
Files 13 13
Lines 1866 1866
=======================================
Hits 1458 1458
Misses 408 408 ☔ View full report in Codecov by Sentry. |
|
Reviewed in person today … looks good. Thanks for tracking down reasons for these changes. The numpy kwarg default on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy appears to have changed what a percentile means with numpy 2.0, as well as maybe what it means to divide.
I added the following lines at the end of 'event_discharge_energy', right before the return statement, in pyxlma.lmalib.flash.properties
I got the following results: https://www.diffchecker.com/lvlbQjU2/ (original is numpy 1.26.4, changed is 2.0.0).
-zinit/8is reported with less precision (maybe a dtypes thing) which trickles down intonp.exp(-(zinit/8.4))(fortunately numpy 2.0 does not change the value of Euler's number, as I had originally suspected), and same thing with the percentile values.somehow specifying the DEFAULT VALUES
rtolandatolkwargs tonp.allclosefixes all of this? I don't understand anything anymore...